sambruk/excalidraw
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: remove click listener for opening popup (#4700)

Browse Source 
* fix: remove click listener for oening popup

* fix
This commit is contained in:
Aakansha Doshi 2022-02-04 20:36:21 +05:30 committed by GitHub
parent de6371aac4
commit 00e30ca0e4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/components/App.tsx
View File

@ -1520,6 +1520,14 @@ class App extends React.Component<AppProps, AppState> {
removePointer = (event: React.PointerEvent<HTMLElement> | PointerEvent) => {
this.lastPointerUp = event;
if (
this.hitLinkElement &&
!this.state.selectedElementIds[this.hitLinkElement.id]
) {
this.redirectToLink();
}
// remove touch handler for context menu on touch devices
if (event.pointerType === "touch" && touchTimeout) {
clearTimeout(touchTimeout);
@ -2404,12 +2412,6 @@ class App extends React.Component<AppProps, AppState> {
}
}
};
private attachLinkListener = () => {
this.canvas?.addEventListener("click", this.redirectToLink);
};
private detachLinkListener = () => {
this.canvas?.removeEventListener("click", this.redirectToLink);
};
private handleCanvasPointerMove = (
event: React.PointerEvent<HTMLCanvasElement>,
@ -2654,10 +2656,8 @@ class App extends React.Component<AppProps, AppState> {
) {
setCursor(this.canvas, CURSOR_TYPE.POINTER);
showHyperlinkTooltip(this.hitLinkElement, this.state);
this.attachLinkListener();
} else {
hideHyperlinkToolip();
this.detachLinkListener();
if (
hitElement &&
hitElement.link &&

1
src/element/Hyperlink.tsx
View File

@ -321,7 +321,6 @@ export const isPointHittingLinkIcon = (
x < linkX + threshold + linkWidth &&
y > linkY - threshold &&
y < linkY + linkHeight + threshold;
return hitLink;
};