sambruk/excalidraw
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix binding disabling when taking screenshots on macOS (#2129)

Browse Source 
* Fix binding disabling when taking screenshots on macOS
* Update snapshot for cmd+click test
This commit is contained in:
Michal Srb
2020-09-03 16:12:01 +02:00
committed by GitHub
parent 924292dc9a
commit 15e4b51bb1
3 changed files with 19 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/components/App.tsx
View File

@ -171,6 +171,7 @@ import {
isLinearElementSimpleAndAlreadyBound,
isBindingEnabled,
updateBoundElements,
shouldEnableBindingForPointerEvent,
} from "../element/binding";
import { MaybeTransformHandleType } from "../element/transformHandles";
@ -2220,6 +2221,7 @@ class App extends React.Component<ExcalidrawProps, AppState> {
}
this.clearSelectionIfNotUsingSelection();
this.updateBindingEnabledOnPointerMove(event);
if (this.handleSelectionOnPointerDown(event, pointerDownState)) {
return;
@ -3484,6 +3486,15 @@ class App extends React.Component<ExcalidrawProps, AppState> {
});
}
private updateBindingEnabledOnPointerMove = (
event: React.PointerEvent<HTMLCanvasElement>,
) => {
const shouldEnableBinding = shouldEnableBindingForPointerEvent(event);
if (this.state.isBindingEnabled !== shouldEnableBinding) {
this.setState({ isBindingEnabled: shouldEnableBinding });
}
};
private maybeSuggestBindingAtCursor = (pointerCoords: {
x: number;
y: number;