sambruk/excalidraw
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: stale appState.pendingImageElement (#5322)

Browse Source 
* fix: stale `appState.pendingImageElement`

* unrelated fix for devTools race conditions

* snap fix
This commit is contained in:
David Luzar
2022-06-19 14:13:43 +02:00
committed by GitHub
parent fd48c2cf79
commit 4712393b62
9 changed files with 107 additions and 103 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
src/tests/__snapshots__/contextmenu.test.tsx.snap
View File

@@ -55,7 +55,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {},
"resizingElement": null,
"scrollX": 0,
@@ -228,7 +228,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {},
"resizingElement": null,
"scrollX": 0,
@@ -405,7 +405,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {},
"resizingElement": null,
"scrollX": 0,
@@ -743,7 +743,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {},
"resizingElement": null,
"scrollX": 0,
@@ -1081,7 +1081,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {},
"resizingElement": null,
"scrollX": 0,
@@ -1258,7 +1258,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {},
"resizingElement": null,
"scrollX": 0,
@@ -1471,7 +1471,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {},
"resizingElement": null,
"scrollX": 0,
@@ -1743,7 +1743,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {
"id1": true,
},
@@ -2099,7 +2099,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {},
"resizingElement": null,
"scrollX": 0,
@@ -2899,7 +2899,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {},
"resizingElement": null,
"scrollX": 0,
@@ -3237,7 +3237,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {},
"resizingElement": null,
"scrollX": 0,
@@ -3575,7 +3575,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {
"id1": true,
},
@@ -3993,7 +3993,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {
"id0": true,
"id2": true,
@@ -4271,7 +4271,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {
"id0": true,
"id2": true,
@@ -4630,7 +4630,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {},
"resizingElement": null,
"scrollX": 0,
@@ -4736,7 +4736,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {},
"resizingElement": null,
"scrollX": 0,
@@ -4820,7 +4820,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {},
"resizingElement": null,
"scrollX": 0,

104
src/tests/__snapshots__/regressionTests.test.tsx.snap
View File

@@ -55,7 +55,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {
"id0": true,
"id1": true,
@@ -564,7 +564,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {
"id0": true,
"id1": true,
@@ -1079,7 +1079,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {},
"resizingElement": null,
"scrollX": 0,
@@ -1939,7 +1939,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {
"id0": true,
},
@@ -2160,7 +2160,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {
"id0": true,
"id3": true,
@@ -2666,7 +2666,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {
"id0": true,
},
@@ -2942,7 +2942,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {},
"resizingElement": null,
"scrollX": 0,
@@ -3119,7 +3119,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {
"id2": true,
},
@@ -3608,7 +3608,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {},
"resizingElement": null,
"scrollX": 0,
@@ -3865,7 +3865,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {
"id0": true,
},
@@ -4086,7 +4086,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {
"id0": true,
"id1": true,
@@ -4351,7 +4351,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {
"id1": true,
},
@@ -4626,7 +4626,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {
"id2": true,
},
@@ -5048,7 +5048,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {
"id0": true,
"id1": true,
@@ -5372,7 +5372,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {
"id0": true,
"id1": true,
@@ -5671,7 +5671,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {
"id0": true,
},
@@ -5898,7 +5898,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {
"id0": true,
},
@@ -6075,7 +6075,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {},
"resizingElement": null,
"scrollX": 0,
@@ -6576,7 +6576,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {
"id0": true,
"id1": true,
@@ -6924,7 +6924,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {},
"resizingElement": null,
"scrollX": 0,
@@ -9163,7 +9163,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {
"id0": true,
"id2": true,
@@ -9561,7 +9561,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {
"id0": true,
"id2": true,
@@ -9837,7 +9837,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {
"id0": true,
"id2": true,
@@ -10074,7 +10074,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {
"id0": true,
"id2": true,
@@ -10380,7 +10380,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {},
"resizingElement": null,
"scrollX": 0,
@@ -10557,7 +10557,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {},
"resizingElement": null,
"scrollX": 0,
@@ -10734,7 +10734,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {},
"resizingElement": null,
"scrollX": 0,
@@ -10911,7 +10911,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {},
"resizingElement": null,
"scrollX": 0,
@@ -11118,7 +11118,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {},
"resizingElement": null,
"scrollX": 0,
@@ -11325,7 +11325,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {},
"resizingElement": null,
"scrollX": 0,
@@ -11550,7 +11550,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {},
"resizingElement": null,
"scrollX": 0,
@@ -11757,7 +11757,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {},
"resizingElement": null,
"scrollX": 0,
@@ -11934,7 +11934,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {},
"resizingElement": null,
"scrollX": 0,
@@ -12141,7 +12141,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {},
"resizingElement": null,
"scrollX": 0,
@@ -12318,7 +12318,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {},
"resizingElement": null,
"scrollX": 0,
@@ -12495,7 +12495,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {},
"resizingElement": null,
"scrollX": 0,
@@ -12720,7 +12720,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {
"id0": true,
"id1": true,
@@ -13514,7 +13514,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {
"id0": true,
"id3": true,
@@ -13790,7 +13790,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {},
"resizingElement": null,
"scrollX": -2.916666666666668,
@@ -13898,7 +13898,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {},
"resizingElement": null,
"scrollX": 0,
@@ -14004,7 +14004,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {
"id0": true,
},
@@ -14184,7 +14184,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {
"id0": true,
"id1": true,
@@ -14535,7 +14535,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {},
"resizingElement": null,
"scrollX": 0,
@@ -14752,7 +14752,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {
"id0": true,
"id1": true,
@@ -15664,7 +15664,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {},
"resizingElement": null,
"scrollX": 60,
@@ -15770,7 +15770,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {
"id0": true,
},
@@ -16609,7 +16609,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {
"id1": true,
"id2": true,
@@ -17056,7 +17056,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {
"id1": true,
},
@@ -17355,7 +17355,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {},
"resizingElement": null,
"scrollX": 10,
@@ -17463,7 +17463,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {},
"resizingElement": null,
"scrollX": 0,
@@ -18007,7 +18007,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {},
"resizingElement": null,
"scrollX": 0,
@@ -18113,7 +18113,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {},
"resizingElement": null,
"scrollX": 0,

2
src/tests/packages/__snapshots__/utils.test.ts.snap
View File

@@ -53,7 +53,7 @@ Object {
},
"penDetected": false,
"penMode": false,
"pendingImageElement": null,
"pendingImageElementId": null,
"previousSelectedElementIds": Object {},
"resizingElement": null,
"scrollX": 0,