sambruk/excalidraw
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix scrollToCenter when no elements supplied (#1222)

Browse Source 
* fix scrollToCenter when no elements supplied

* make getCommonBounds return default values on empty elements
This commit is contained in:
David Luzar 2020-04-04 18:45:14 +02:00 committed by GitHub
parent b97520400a
commit 4dd947b261
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/element/bounds.ts
View File

@ -187,6 +187,10 @@ export function getArrowPoints(
} }
export function getCommonBounds(elements: readonly ExcalidrawElement[]) { export function getCommonBounds(elements: readonly ExcalidrawElement[]) {
if (!elements.length) {
return [0, 0, 0, 0];
}
let minX = Infinity; let minX = Infinity;
let maxX = -Infinity; let maxX = -Infinity;
let minY = Infinity; let minY = Infinity;

7
src/scene/scroll.ts
View File

@ -9,6 +9,13 @@ export function normalizeScroll(pos: number) {
export function calculateScrollCenter( export function calculateScrollCenter(
elements: readonly ExcalidrawElement[], elements: readonly ExcalidrawElement[],
): { scrollX: FlooredNumber; scrollY: FlooredNumber } { ): { scrollX: FlooredNumber; scrollY: FlooredNumber } {
if (!elements.length) {
return {
scrollX: normalizeScroll(0),
scrollY: normalizeScroll(0),
};
}
const [x1, y1, x2, y2] = getCommonBounds(elements); const [x1, y1, x2, y2] = getCommonBounds(elements);
const centerX = (x1 + x2) / 2; const centerX = (x1 + x2) / 2;