sambruk/excalidraw
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

15-degree rotation locking (#1627)

Browse Source
This commit is contained in:
Daishi Kato 2020-05-23 17:45:05 +09:00 committed by GitHub
parent d2ae18995c
commit 51608c07b0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/constants.ts
View File

@ -3,7 +3,7 @@ export const LINE_CONFIRM_THRESHOLD = 10; // 10px
export const ELEMENT_SHIFT_TRANSLATE_AMOUNT = 5; export const ELEMENT_SHIFT_TRANSLATE_AMOUNT = 5;
export const ELEMENT_TRANSLATE_AMOUNT = 1; export const ELEMENT_TRANSLATE_AMOUNT = 1;
export const TEXT_TO_CENTER_SNAP_THRESHOLD = 30; export const TEXT_TO_CENTER_SNAP_THRESHOLD = 30;
export const SHIFT_LOCKING_ANGLE = Math.PI / 8; export const SHIFT_LOCKING_ANGLE = Math.PI / 12;
export const CURSOR_TYPE = { export const CURSOR_TYPE = {
TEXT: "text", TEXT: "text",
CROSSHAIR: "crosshair", CROSSHAIR: "crosshair",

8
src/element/sizeHelpers.test.ts
View File

@ -3,17 +3,17 @@ import * as constants from "../constants";
describe("getPerfectElementSize", () => { describe("getPerfectElementSize", () => {
it("should return height:0 if `elementType` is line and locked angle is 0", () => { it("should return height:0 if `elementType` is line and locked angle is 0", () => {
const { height, width } = getPerfectElementSize("line", 149, 20); const { height, width } = getPerfectElementSize("line", 149, 10);
expect(width).toEqual(149); expect(width).toEqual(149);
expect(height).toEqual(0); expect(height).toEqual(0);
}); });
it("should return width:0 if `elementType` is line and locked angle is 90 deg (Math.PI/2)", () => { it("should return width:0 if `elementType` is line and locked angle is 90 deg (Math.PI/2)", () => {
const { height, width } = getPerfectElementSize("line", 20, 140); const { height, width } = getPerfectElementSize("line", 10, 140);
expect(width).toEqual(0); expect(width).toEqual(0);
expect(height).toEqual(140); expect(height).toEqual(140);
}); });
it("should return height:0 if `elementType` is arrow and locked angle is 0", () => { it("should return height:0 if `elementType` is arrow and locked angle is 0", () => {
const { height, width } = getPerfectElementSize("arrow", 200, 30); const { height, width } = getPerfectElementSize("arrow", 200, 20);
expect(width).toEqual(200); expect(width).toEqual(200);
expect(height).toEqual(0); expect(height).toEqual(0);
}); });
@ -25,7 +25,7 @@ describe("getPerfectElementSize", () => {
it("should return adjust height to be width * tan(locked angle)", () => { it("should return adjust height to be width * tan(locked angle)", () => {
const { height, width } = getPerfectElementSize("arrow", 120, 185); const { height, width } = getPerfectElementSize("arrow", 120, 185);
expect(width).toEqual(120); expect(width).toEqual(120);
expect(height).toEqual(290); expect(height).toEqual(208);
}); });
it("should return height equals to width if locked angle is 45 deg", () => { it("should return height equals to width if locked angle is 45 deg", () => {
const { height, width } = getPerfectElementSize("arrow", 135, 145); const { height, width } = getPerfectElementSize("arrow", 135, 145);