sambruk/excalidraw
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: restore cursor position after bound text container value updated (#4836)

Browse Source 
* fix: restore cursor position after bound text container value updated

* only restore cursor when the cursor is not at the end of the line

* compute diff before setting the cursor
This commit is contained in:
Aakansha Doshi 2022-02-22 18:24:06 +05:30 committed by GitHub
parent b2d49155ef
commit 5cf7087754
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/element/textWysiwyg.tsx
View File

@ -165,7 +165,24 @@ export const textWysiwyg = ({
} }
const [viewportX, viewportY] = getViewportCoords(coordX, coordY); const [viewportX, viewportY] = getViewportCoords(coordX, coordY);
const { textAlign } = updatedElement; const { textAlign } = updatedElement;
const initialSelectionStart = editable.selectionStart;
const initialSelectionEnd = editable.selectionEnd;
const initialLength = editable.value.length;
editable.value = updatedElement.originalText; editable.value = updatedElement.originalText;
// restore cursor positon after value updated so it doesn't
// go to the end of text when container auto expanded
if (
initialSelectionStart === initialSelectionEnd &&
initialSelectionEnd !== initialLength
) {
// get diff between length and selection end and shift
// the cursor by "diff" times to position correctly
const diff = initialLength - initialSelectionEnd;
editable.selectionStart = editable.value.length - diff;
editable.selectionEnd = editable.value.length - diff;
}
const lines = updatedElement.originalText.split("\n"); const lines = updatedElement.originalText.split("\n");
const lineHeight = updatedElement.containerId const lineHeight = updatedElement.containerId
? approxLineHeight ? approxLineHeight