sambruk/excalidraw
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: React.memo resolvers not accounting for all props (#6042)

Browse Source
This commit is contained in:
David Luzar
2023-01-09 10:24:17 +01:00
committed by GitHub
parent 06b45e0cfc
commit 618442299f
3 changed files with 54 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/packages/excalidraw/index.tsx
View File

@ -1,6 +1,7 @@
import React, { useEffect, forwardRef } from "react";
import { InitializeApp } from "../../components/InitializeApp";
import App from "../../components/App";
import { isShallowEqual } from "../../utils";
import "../../css/app.scss";
import "../../css/styles.scss";
@ -128,6 +129,11 @@ const areEqual = (
prevProps: PublicExcalidrawProps,
nextProps: PublicExcalidrawProps,
) => {
// short-circuit early
if (prevProps.children !== nextProps.children) {
return false;
}
const {
initialData: prevInitialData,
UIOptions: prevUIOptions = {},
@ -176,13 +182,7 @@ const areEqual = (
return true;
});
const prevKeys = Object.keys(prevProps) as (keyof typeof prev)[];
const nextKeys = Object.keys(nextProps) as (keyof typeof next)[];
return (
isUIOptionsSame &&
prevKeys.length === nextKeys.length &&
prevKeys.every((key) => prev[key] === next[key])
);
return isUIOptionsSame && isShallowEqual(prev, next);
};
const forwardedRefComp = forwardRef<