sambruk/excalidraw
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Allow copy pasting inside of wysiwyg element (#651)

Browse Source 
We did some hackery to prevent copy pasting when we didn't support multilines. But we do now so we can remove it.

Interestingly, newlines are actually <br /> elements. So we need to tweak the isInputLike logic a bit
This commit is contained in:
Christopher Chedeau 2020-02-01 04:06:27 +00:00 committed by GitHub
parent f261d6f2fc
commit 70db792549
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/element/textWysiwyg.tsx
View File

@ -73,14 +73,6 @@ export function textWysiwyg({
} }
}; };
editable.onblur = handleSubmit; editable.onblur = handleSubmit;
// override paste to disallow non-textual data, and replace newlines
editable.onpaste = ev => {
ev.preventDefault();
try {
const text = ev.clipboardData!.getData("text").replace(/\n+/g, " ");
editable.textContent = text;
} catch {}
};
function stopEvent(ev: Event) { function stopEvent(ev: Event) {
ev.stopPropagation(); ev.stopPropagation();
@ -98,7 +90,6 @@ export function textWysiwyg({
function cleanup() { function cleanup() {
editable.onblur = null; editable.onblur = null;
editable.onkeydown = null; editable.onkeydown = null;
editable.onpaste = null;
window.removeEventListener("wheel", stopEvent, true); window.removeEventListener("wheel", stopEvent, true);
document.body.removeChild(editable); document.body.removeChild(editable);
} }

1
src/utils.ts
View File

@ -31,6 +31,7 @@ export function isInputLike(
| HTMLDivElement { | HTMLDivElement {
return ( return (
(target instanceof HTMLElement && target.dataset.type === "wysiwyg") || (target instanceof HTMLElement && target.dataset.type === "wysiwyg") ||
target instanceof HTMLBRElement || // newline in wysiwyg
target instanceof HTMLInputElement || target instanceof HTMLInputElement ||
target instanceof HTMLTextAreaElement || target instanceof HTMLTextAreaElement ||
target instanceof HTMLSelectElement target instanceof HTMLSelectElement