sambruk/excalidraw
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix text selection broken by PR1899 (#2011)

Browse Source
This commit is contained in:
Michal Srb 2020-08-09 00:51:41 -07:00 committed by GitHub
parent 26f67d27ec
commit 8bbeb32e87
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/element/collision.ts
View File

@ -48,9 +48,12 @@ export const hitTest = (
): boolean => { ): boolean => {
// How many pixels off the shape boundary we still consider a hit // How many pixels off the shape boundary we still consider a hit
const threshold = 10 / appState.zoom; const threshold = 10 / appState.zoom;
const check = isElementDraggableFromInside(element, appState) const check =
? isInsideCheck element.type === "text"
: isNearCheck; ? isStrictlyInside
: isElementDraggableFromInside(element, appState)
? isInsideCheck
: isNearCheck;
const point: Point = [x, y]; const point: Point = [x, y];
return hitTestPointAgainstElement({ element, point, threshold, check }); return hitTestPointAgainstElement({ element, point, threshold, check });
}; };
@ -119,6 +122,10 @@ export const distanceToBindableElement = (
} }
}; };
const isStrictlyInside = (distance: number, threshold: number): boolean => {
return distance < 0;
};
const isInsideCheck = (distance: number, threshold: number): boolean => { const isInsideCheck = (distance: number, threshold: number): boolean => {
return distance < threshold; return distance < threshold;
}; };