From 925db9dcca58f125a4585b4d11b89b41c3792f6f Mon Sep 17 00:00:00 2001
From: Christopher Chedeau <vjeuxx@gmail.com>
Date: Mon, 27 Jul 2020 14:05:52 -0700
Subject: [PATCH] Only insert text on double click when selection is enabled
 (#1937)

This was an oversight to enable it for all the shapes. I don't believe that we want to be able to insert text on double click when drawing a rectangle for example. And it's definitely a broken experience when doing so for free draw.

Fixes part of #1935
---
 src/components/App.tsx | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/components/App.tsx b/src/components/App.tsx
index 244aef79..831e5100 100644
--- a/src/components/App.tsx
+++ b/src/components/App.tsx
@@ -1746,6 +1746,10 @@ class App extends React.Component<ExcalidrawProps, AppState> {
     if (this.state.multiElement) {
       return;
     }
+    // we should only be able to double click when mode is selection
+    if (this.state.elementType !== "selection") {
+      return;
+    }
 
     const selectedElements = getSelectedElements(
       globalSceneState.getElements(),