sambruk/excalidraw
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: use ideographic textBaseline to improve layout shift when editing text (#6384)

Browse Source
This commit is contained in:
David Luzar 2023-03-22 18:33:37 +01:00 committed by GitHub
parent 83383977f5
commit 9e52c30ce8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/renderer/renderElement.ts
View File

@ -34,6 +34,7 @@ import { AppState, BinaryFiles, Zoom } from "../types";
import { getDefaultAppState } from "../appState"; import { getDefaultAppState } from "../appState";
import { import {
BOUND_TEXT_PADDING, BOUND_TEXT_PADDING,
FONT_FAMILY,
MAX_DECIMALS_FOR_SVG_EXPORT, MAX_DECIMALS_FOR_SVG_EXPORT,
MIME_TYPES, MIME_TYPES,
SVG_NS, SVG_NS,
@ -286,7 +287,13 @@ const drawElementOnCanvas = (
: element.textAlign === "right" : element.textAlign === "right"
? element.width ? element.width
: 0; : 0;
context.textBaseline = "bottom";
// FIXME temporary hack
context.textBaseline =
element.fontFamily === FONT_FAMILY.Virgil ||
element.fontFamily === FONT_FAMILY.Cascadia
? "ideographic"
: "bottom";
const lineHeightPx = getLineHeightInPx( const lineHeightPx = getLineHeightInPx(
element.fontSize, element.fontSize,