sambruk/excalidraw
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: not cloning elements on export polluting Scene mapping (#7276)

Browse Source
This commit is contained in:
David Luzar 2023-11-12 23:32:12 +01:00 committed by GitHub
parent 3d4ff59f40
commit ae5b9a4ffd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/scene/export.ts
View File

@ -11,7 +11,7 @@ import {
getElementAbsoluteCoords, getElementAbsoluteCoords,
} from "../element/bounds"; } from "../element/bounds";
import { renderSceneToSvg, renderStaticScene } from "../renderer/renderScene"; import { renderSceneToSvg, renderStaticScene } from "../renderer/renderScene";
import { distance, getFontString } from "../utils"; import { cloneJSON, distance, getFontString } from "../utils";
import { AppState, BinaryFiles } from "../types"; import { AppState, BinaryFiles } from "../types";
import { import {
DEFAULT_EXPORT_PADDING, DEFAULT_EXPORT_PADDING,
@ -52,8 +52,9 @@ const __createSceneForElementsHack__ = (
// we can't duplicate elements to regenerate ids because we need the // we can't duplicate elements to regenerate ids because we need the
// orig ids when embedding. So we do another hack of not mapping element // orig ids when embedding. So we do another hack of not mapping element
// ids to Scene instances so that we don't override the editor elements // ids to Scene instances so that we don't override the editor elements
// mapping // mapping.
scene.replaceAllElements(elements, false); // We still need to clone the objects themselves to regen references.
scene.replaceAllElements(cloneJSON(elements), false);
return scene; return scene;
}; };