sambruk/excalidraw
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: call static methods via class instead of instance in linearElementEditor (#5561)

Browse Source 
* fix: call getMidPoint via class instead of instance

* fix

* fix
This commit is contained in:
Aakansha Doshi 2022-08-11 20:33:07 +05:30 committed by GitHub
parent 5a8dbe8030
commit b67a2b4f65
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/element/linearElementEditor.ts
View File

@ -386,7 +386,7 @@ export class LinearElementEditor {
return false; return false;
} }
const midPoint = this.getMidPoint(linearElementEditor); const midPoint = LinearElementEditor.getMidPoint(linearElementEditor);
if (midPoint) { if (midPoint) {
const threshold = const threshold =
LinearElementEditor.POINT_HANDLE_SIZE / appState.zoom.value; LinearElementEditor.POINT_HANDLE_SIZE / appState.zoom.value;
@ -453,7 +453,7 @@ export class LinearElementEditor {
appState, appState,
) )
) { ) {
const midPoint = this.getMidPoint(linearElementEditor); const midPoint = LinearElementEditor.getMidPoint(linearElementEditor);
if (midPoint) { if (midPoint) {
mutateElement(element, { mutateElement(element, {
points: [ points: [
@ -715,7 +715,8 @@ export class LinearElementEditor {
x: number, x: number,
y: number, y: number,
) { ) {
const pointHandles = this.getPointsGlobalCoordinates(element); const pointHandles =
LinearElementEditor.getPointsGlobalCoordinates(element);
let idx = pointHandles.length; let idx = pointHandles.length;
// loop from right to left because points on the right are rendered over // loop from right to left because points on the right are rendered over
// points on the left, thus should take precedence when clicking, if they // points on the left, thus should take precedence when clicking, if they
@ -725,7 +726,7 @@ export class LinearElementEditor {
if ( if (
distance2d(x, y, point[0], point[1]) * zoom.value < distance2d(x, y, point[0], point[1]) * zoom.value <
// +1px to account for outline stroke // +1px to account for outline stroke
this.POINT_HANDLE_SIZE + 1 LinearElementEditor.POINT_HANDLE_SIZE + 1
) { ) {
return idx; return idx;
} }