feat: Add scroll listener to the nearest scrollable container and allow consumer to disable it (#3408)

* fix: Add scroll listener to the nearest scrollable container

* fix

* use loop instead of recursion

* fix

* return document

* calculate nearest scrollable container in settimeout to unblock main thread

* Add prop detectNearestScroll and clear timeout on unmount

* disable scroll listener on excal app

* update prop name to detectScroll

* update docs

* remove settimeout

* tweak docs

Co-authored-by: David Luzar <luzar.david@gmail.com>

* tweak changelog

Co-authored-by: David Luzar <luzar.david@gmail.com>

* lint

Co-authored-by: David Luzar <luzar.david@gmail.com>
This commit is contained in:
Aakansha Doshi
2021-04-09 20:44:54 +05:30
committed by GitHub
parent d91950bd03
commit c19c8ecd27
8 changed files with 47 additions and 8 deletions

View File

@ -195,6 +195,7 @@ export interface ExcalidrawProps {
appState: AppState,
) => JSX.Element;
UIOptions?: UIOptions;
detectScroll?: boolean;
}
export type SceneData = {
@ -228,4 +229,5 @@ export type AppProps = ExcalidrawProps & {
UIOptions: {
canvasActions: Required<CanvasActions>;
};
detectScroll: boolean;
};