sambruk/excalidraw
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: update viewport coords correctly when editing text (#4416)

Browse Source
This commit is contained in:
Aakansha Doshi 2021-12-17 16:08:18 +05:30 committed by GitHub
parent ff1d7728a0
commit c2a8712593
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/components/App.tsx
View File

@ -1916,7 +1916,10 @@ class App extends React.Component<AppProps, AppState> {
}, },
this.state, this.state,
); );
return [viewportX, viewportY]; return [
viewportX - this.state.offsetLeft,
viewportY - this.state.offsetTop,
];
}, },
onChange: withBatchedUpdates((text) => { onChange: withBatchedUpdates((text) => {
updateElement(text, text, false, !element.containerId); updateElement(text, text, false, !element.containerId);

4
src/element/textWysiwyg.tsx
View File

@ -426,10 +426,10 @@ export const textWysiwyg = ({
if (isTextElement(updateElement) && updateElement.containerId) { if (isTextElement(updateElement) && updateElement.containerId) {
if (editable.value) { if (editable.value) {
mutateElement(updateElement, { mutateElement(updateElement, {
y, y: y + appState.offsetTop,
height: Number(editable.style.height.slice(0, -2)), height: Number(editable.style.height.slice(0, -2)),
width: Number(editable.style.width.slice(0, -2)), width: Number(editable.style.width.slice(0, -2)),
x, x: x + appState.offsetLeft,
}); });
const boundTextElementId = getBoundTextElementId(container); const boundTextElementId = getBoundTextElementId(container);
if (!boundTextElementId || boundTextElementId !== element.id) { if (!boundTextElementId || boundTextElementId !== element.id) {