sambruk/excalidraw
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: improperly cache-busting on canvas scale instead of zoom (#6473)

Browse Source
This commit is contained in:
David Luzar 2023-04-17 11:41:27 +02:00 committed by GitHub
parent f640ddc2aa
commit c3e8ddaf58
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/renderer/renderElement.ts
View File

@ -88,6 +88,7 @@ export interface ExcalidrawElementWithCanvas {
canvas: HTMLCanvasElement; canvas: HTMLCanvasElement;
theme: RenderConfig["theme"]; theme: RenderConfig["theme"];
scale: number; scale: number;
zoomValue: RenderConfig["zoom"]["value"];
canvasOffsetX: number; canvasOffsetX: number;
canvasOffsetY: number; canvasOffsetY: number;
boundTextElementVersion: number | null; boundTextElementVersion: number | null;
@ -202,6 +203,7 @@ const generateElementCanvas = (
canvas, canvas,
theme: renderConfig.theme, theme: renderConfig.theme,
scale, scale,
zoomValue: zoom.value,
canvasOffsetX, canvasOffsetX,
canvasOffsetY, canvasOffsetY,
boundTextElementVersion: getBoundTextElement(element)?.version || null, boundTextElementVersion: getBoundTextElement(element)?.version || null,
@ -712,7 +714,7 @@ const generateElementWithCanvas = (
const prevElementWithCanvas = elementWithCanvasCache.get(element); const prevElementWithCanvas = elementWithCanvasCache.get(element);
const shouldRegenerateBecauseZoom = const shouldRegenerateBecauseZoom =
prevElementWithCanvas && prevElementWithCanvas &&
prevElementWithCanvas.scale !== zoom.value && prevElementWithCanvas.zoomValue !== zoom.value &&
!renderConfig?.shouldCacheIgnoreZoom; !renderConfig?.shouldCacheIgnoreZoom;
const boundTextElementVersion = getBoundTextElement(element)?.version || null; const boundTextElementVersion = getBoundTextElement(element)?.version || null;