sambruk/excalidraw
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Reduce the maximum size of the binding gap (#2450)

Browse Source
This commit is contained in:
Lipis 2020-12-09 15:03:25 +02:00 committed by GitHub
parent 4d71078f48
commit c7b5cdb71e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/element/collision.ts
View File

@ -133,7 +133,7 @@ export const maxBindingGap = (
const shapeRatio = element.type === "diamond" ? 1 / Math.sqrt(2) : 1; const shapeRatio = element.type === "diamond" ? 1 / Math.sqrt(2) : 1;
const smallerDimension = shapeRatio * Math.min(elementWidth, elementHeight); const smallerDimension = shapeRatio * Math.min(elementWidth, elementHeight);
// We make the bindable boundary bigger for bigger elements // We make the bindable boundary bigger for bigger elements
return Math.max(15, Math.min(0.25 * smallerDimension, 80)); return Math.max(16, Math.min(0.25 * smallerDimension, 32));
}; };
type HitTestArgs = { type HitTestArgs = {

4
src/tests/binding.test.tsx
View File

@ -27,9 +27,9 @@ describe("element binding", () => {
height: 500, height: 500,
}); });
const arrow = UI.createElement("arrow", { const arrow = UI.createElement("arrow", {
x: 220, x: 210,
y: 250, y: 250,
width: 160, width: 180,
height: 1, height: 1,
}); });
expect(arrow.startBinding?.elementId).toBe(rectLeft.id); expect(arrow.startBinding?.elementId).toBe(rectLeft.id);