sambruk/excalidraw
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: mobile context menu won't show on long press (#4741)

Browse Source 
* scribble fix only if not Android

* Update src/components/App.tsx

Co-authored-by: David Luzar <luzar.david@gmail.com>
This commit is contained in:
zsviczian 2022-02-07 19:46:29 +01:00 committed by GitHub
parent 66c92fc65a
commit d450c36581
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/components/App.tsx
View File

@ -163,6 +163,7 @@ import {
shouldRotateWithDiscreteAngle, shouldRotateWithDiscreteAngle,
isArrowKey, isArrowKey,
KEYS, KEYS,
isAndroid,
} from "../keys"; } from "../keys";
import { distance2d, getGridPoint, isPathALoop } from "../math"; import { distance2d, getGridPoint, isPathALoop } from "../math";
import { renderScene } from "../renderer"; import { renderScene } from "../renderer";
@ -1274,7 +1275,10 @@ class App extends React.Component<AppProps, AppState> {
private onTapStart = (event: TouchEvent) => { private onTapStart = (event: TouchEvent) => {
// fix for Apple Pencil Scribble // fix for Apple Pencil Scribble
event.preventDefault(); // On Android, preventing the event would disable contextMenu on tap-hold
if (!isAndroid) {
event.preventDefault();
}
if (!didTapTwice) { if (!didTapTwice) {
didTapTwice = true; didTapTwice = true;
@ -1297,6 +1301,9 @@ class App extends React.Component<AppProps, AppState> {
didTapTwice = false; didTapTwice = false;
clearTimeout(tappedTwiceTimer); clearTimeout(tappedTwiceTimer);
} }
if (isAndroid) {
event.preventDefault();
}
if (event.touches.length === 2) { if (event.touches.length === 2) {
this.setState({ this.setState({

1
src/keys.ts
View File

@ -1,5 +1,6 @@
export const isDarwin = /Mac|iPod|iPhone|iPad/.test(window.navigator.platform); export const isDarwin = /Mac|iPod|iPhone|iPad/.test(window.navigator.platform);
export const isWindows = /^Win/.test(window.navigator.platform); export const isWindows = /^Win/.test(window.navigator.platform);
export const isAndroid = /\b(android)\b/i.test(navigator.userAgent);
export const CODES = { export const CODES = {
EQUAL: "Equal", EQUAL: "Equal",