sambruk/excalidraw
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: dialog remounting on className updates (#7224)

Browse Source
This commit is contained in:
David Luzar 2023-11-02 16:06:15 +01:00 committed by GitHub
parent 81c0259041
commit d8166d9e1d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/hooks/useCreatePortalContainer.ts
View File

@ -17,9 +17,13 @@ export const useCreatePortalContainer = (opts?: {
useLayoutEffect(() => { useLayoutEffect(() => {
if (div) { if (div) {
div.className = "";
div.classList.add("excalidraw", ...(opts?.className?.split(/\s+/) || []));
div.classList.toggle("excalidraw--mobile", device.isMobile); div.classList.toggle("excalidraw--mobile", device.isMobile);
div.classList.toggle("excalidraw--mobile", isMobileRef.current);
div.classList.toggle("theme--dark", theme === "dark");
} }
}, [div, device.isMobile]); }, [div, theme, device.isMobile, opts?.className]);
useLayoutEffect(() => { useLayoutEffect(() => {
const container = opts?.parentSelector const container = opts?.parentSelector
@ -32,10 +36,6 @@ export const useCreatePortalContainer = (opts?: {
const div = document.createElement("div"); const div = document.createElement("div");
div.classList.add("excalidraw", ...(opts?.className?.split(/\s+/) || []));
div.classList.toggle("excalidraw--mobile", isMobileRef.current);
div.classList.toggle("theme--dark", theme === "dark");
container.appendChild(div); container.appendChild(div);
setDiv(div); setDiv(div);
@ -43,7 +43,7 @@ export const useCreatePortalContainer = (opts?: {
return () => { return () => {
container.removeChild(div); container.removeChild(div);
}; };
}, [excalidrawContainer, theme, opts?.className, opts?.parentSelector]); }, [excalidrawContainer, opts?.parentSelector]);
return div; return div;
}; };