sambruk/excalidraw
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Abstract away or eliminate most of the mutation of the Elements array (#955)

Browse Source
This commit is contained in:
Pete Hunt
2020-03-14 21:48:51 -07:00
committed by GitHub
parent 05af9f04ed
commit e1e2249f57
17 changed files with 293 additions and 272 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/renderer/renderElement.ts
View File

@ -7,7 +7,6 @@ import {
} from "../element/bounds";
import { RoughCanvas } from "roughjs/bin/canvas";
import { Drawable } from "roughjs/bin/core";
import { Point } from "roughjs/bin/geometry";
import { RoughSVG } from "roughjs/bin/svg";
import { RoughGenerator } from "roughjs/bin/generator";
import { SceneState } from "../scene/types";
@ -214,13 +213,11 @@ function generateElement(
};
// points array can be empty in the beginning, so it is important to add
// initial position to it
const points: Point[] = element.points.length
? element.points
: [[0, 0]];
const points = element.points.length ? element.points : [[0, 0]];
// curve is always the first element
// this simplifies finding the curve for an element
shape = [generator.curve(points, options)];
shape = [generator.curve(points as [number, number][], options)];
// add lines only in arrow
if (element.type === "arrow") {