fix: Wrap excalidraw in position relative & hide scrollbars in zen mode (#3174)

* fix: wrap excalidraw in position relative so that host need not add it explicitly to fix positioning when non zero offsets

* patch version

* Hide scrollbars on excalidraw container

* remove overflow hidden from index.html since its handled in excalidraw container

* review fix

* update changelog
This commit is contained in:
Aakansha Doshi 2021-03-06 20:11:26 +05:30 committed by GitHub
parent 07e71a8071
commit eb24e8ffe4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 12 additions and 7 deletions

View File

@ -116,7 +116,6 @@
user-select: none; user-select: none;
width: 100vw; width: 100vw;
height: 100vh; height: 100vh;
overflow: hidden;
} }
.visually-hidden { .visually-hidden {

View File

@ -414,8 +414,6 @@ class App extends React.Component<ExcalidrawProps, AppState> {
zenModeEnabled, zenModeEnabled,
width: canvasDOMWidth, width: canvasDOMWidth,
height: canvasDOMHeight, height: canvasDOMHeight,
offsetTop,
offsetLeft,
viewModeEnabled, viewModeEnabled,
} = this.state; } = this.state;
@ -433,8 +431,6 @@ class App extends React.Component<ExcalidrawProps, AppState> {
style={{ style={{
width: canvasDOMWidth, width: canvasDOMWidth,
height: canvasDOMHeight, height: canvasDOMHeight,
top: offsetTop,
left: offsetLeft,
}} }}
> >
<LayerUI <LayerUI

View File

@ -8,6 +8,8 @@
} }
.excalidraw { .excalidraw {
position: relative;
overflow: hidden;
color: var(--text-primary-color); color: var(--text-primary-color);
display: flex; display: flex;
top: 0; top: 0;

View File

@ -12,13 +12,21 @@ The change should be grouped under one of the below section and must contain PR
Please add the latest change on the top under the correct section. Please add the latest change on the top under the correct section.
--> -->
## Unreleased ## 0.4.2
## Excalidraw API ## Excalidraw API
### Fixes ### Fixes
- Wrap excalidraw in position relative so host need not do it anymore & hide scrollbars in zen mode [#3174](https://github.com/excalidraw/excalidraw/pull/3174).
- Reduce the scroll debounce timeout to `100ms` so `offsets` gets updated faster if changed when container scrolled [#3182](https://github.com/excalidraw/excalidraw/pull/3182). - Reduce the scroll debounce timeout to `100ms` so `offsets` gets updated faster if changed when container scrolled [#3182](https://github.com/excalidraw/excalidraw/pull/3182).
- Rerender UI on `renderFooter` prop change [#3183](https://github.com/excalidraw/excalidraw/pull/3183)
## Excalidraw Library
### Fixes
- Temporarily downgrade browser-fs-access to fix legacy FS API [#3172](https://github.com/excalidraw/excalidraw/pull/3172)
--- ---

View File

@ -1,6 +1,6 @@
{ {
"name": "@excalidraw/excalidraw", "name": "@excalidraw/excalidraw",
"version": "0.4.1", "version": "0.4.2",
"main": "dist/excalidraw.min.js", "main": "dist/excalidraw.min.js",
"files": [ "files": [
"dist/*" "dist/*"