sambruk/excalidraw
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: bind text to correct container when nested (#5307)

Browse Source 
* fix: bind text to correct container when nested

* fix tests
This commit is contained in:
Aakansha Doshi 2022-06-15 16:09:12 +05:30 committed by GitHub
parent ddf088e428
commit ec35d5db51
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/components/App.tsx
View File

@ -2224,12 +2224,13 @@ class App extends React.Component<AppProps, AppState> {
existingTextElement = selectedElements[0]; existingTextElement = selectedElements[0];
} else if (isTextBindableContainer(selectedElements[0], false)) { } else if (isTextBindableContainer(selectedElements[0], false)) {
existingTextElement = getBoundTextElement(selectedElements[0]); existingTextElement = getBoundTextElement(selectedElements[0]);
} else {
existingTextElement = this.getTextElementAtPosition(sceneX, sceneY);
} }
} else {
existingTextElement = this.getTextElementAtPosition(sceneX, sceneY);
} }
existingTextElement =
existingTextElement ?? this.getTextElementAtPosition(sceneX, sceneY);
// bind to container when shouldBind is true or // bind to container when shouldBind is true or
// clicked on center of container // clicked on center of container
if ( if (

3
src/element/textWysiwyg.test.tsx
View File

@ -115,6 +115,9 @@ describe("textWysiwyg", () => {
height: textSize, height: textSize,
containerId: container.id, containerId: container.id,
}); });
mutateElement(container, {
boundElements: [{ type: "text", id: text.id }],
});
h.elements = [container, text]; h.elements = [container, text];