perf: improve element in frame check (#7124)
This commit is contained in:
parent
03da9112cf
commit
f20ba90ffa
11
src/frame.ts
11
src/frame.ts
@ -707,6 +707,17 @@ export const isElementInFrame = (
|
|||||||
: element;
|
: element;
|
||||||
|
|
||||||
if (frame) {
|
if (frame) {
|
||||||
|
// Perf improvement:
|
||||||
|
// For an element that's already in a frame, if it's not being dragged
|
||||||
|
// then there is no need to refer to geometry (which, yes, is slow) to check if it's in a frame.
|
||||||
|
// It has to be in its containing frame.
|
||||||
|
if (
|
||||||
|
!appState.selectedElementIds[element.id] ||
|
||||||
|
!appState.selectedElementsAreBeingDragged
|
||||||
|
) {
|
||||||
|
return true;
|
||||||
|
}
|
||||||
|
|
||||||
if (_element.groupIds.length === 0) {
|
if (_element.groupIds.length === 0) {
|
||||||
return elementOverlapsWithFrame(_element, frame);
|
return elementOverlapsWithFrame(_element, frame);
|
||||||
}
|
}
|
||||||
|
Loading…
x
Reference in New Issue
Block a user