sambruk/excalidraw
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: check if process is defined before using so it works in browser (#4497)

Browse Source 
* refactor: use isTestEnv() utils where applicable

* check if process is defined
This commit is contained in:
Aakansha Doshi 2021-12-28 17:17:41 +05:30 committed by GitHub
parent 38236bc5e0
commit 11396a21de
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/element/newElement.ts
View File

@ -13,7 +13,7 @@ import {
FontFamilyValues,
ExcalidrawRectangleElement,
} from "../element/types";
import { getFontString, getUpdatedTimestamp } from "../utils";
import { getFontString, getUpdatedTimestamp, isTestEnv } from "../utils";
import { randomInteger, randomId } from "../random";
import { mutateElement, newElementWith } from "./mutateElement";
import { getNewGroupIdsForDuplication } from "../groups";
@ -369,7 +369,7 @@ export const duplicateElement = <TElement extends Mutable<ExcalidrawElement>>(
overrides?: Partial<TElement>,
): TElement => {
let copy: TElement = deepCopyElement(element);
if (process.env.NODE_ENV === "test") {
if (isTestEnv()) {
copy.id = `${copy.id}_copy`;
// `window.h` may not be defined in some unit tests
if (

4
src/random.ts
View File

@ -1,5 +1,6 @@
import { Random } from "roughjs/bin/math";
import { nanoid } from "nanoid";
import { isTestEnv } from "./utils";
let random = new Random(Date.now());
let testIdBase = 0;
@ -11,5 +12,4 @@ export const reseed = (seed: number) => {
testIdBase = 0;
};
export const randomId = () =>
process.env.NODE_ENV === "test" ? `id${testIdBase++}` : nanoid();
export const randomId = () => (isTestEnv() ? `id${testIdBase++}` : nanoid());

6
src/utils.ts
View File

@ -443,8 +443,7 @@ export const bytesToHexString = (bytes: Uint8Array) => {
.join("");
};
export const getUpdatedTimestamp = () =>
process.env.NODE_ENV === "test" ? 1 : Date.now();
export const getUpdatedTimestamp = () => (isTestEnv() ? 1 : Date.now());
/**
* Transforms array of objects containing `id` attribute,
@ -459,4 +458,5 @@ export const arrayToMap = <T extends { id: string } | string>(
}, new Map());
};
export const isTestEnv = () => process?.env?.NODE_ENV === "test";
export const isTestEnv = () =>
typeof process !== "undefined" && process.env?.NODE_ENV === "test";