sambruk/excalidraw
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: adding check for link length to prevent early return (#4982)

Browse Source 
Co-authored-by: Connor Hanafee <connorp@Connors-MacBook-Pro.local>
Co-authored-by: dwelle <luzar.david@gmail.com>
This commit is contained in:
connorhanafee 2022-03-27 22:50:41 +01:00 committed by GitHub
parent 127af9db23
commit 580e719580
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/components/App.tsx
View File

@ -2409,13 +2409,13 @@ class App extends React.Component<AppProps, AppState> {
}
return (
element.link &&
index <= hitElementIndex &&
isPointHittingLinkIcon(
element,
this.state,
[scenePointer.x, scenePointer.y],
this.deviceType.isMobile,
) &&
index <= hitElementIndex
)
);
});
};
@ -2443,7 +2443,7 @@ class App extends React.Component<AppProps, AppState> {
this.state,
);
const lastPointerDownHittingLinkIcon = isPointHittingLinkIcon(
this.hitLinkElement!,
this.hitLinkElement,
this.state,
[lastPointerDownCoords.x, lastPointerDownCoords.y],
this.deviceType.isMobile,
@ -2453,7 +2453,7 @@ class App extends React.Component<AppProps, AppState> {
this.state,
);
const lastPointerUpHittingLinkIcon = isPointHittingLinkIcon(
this.hitLinkElement!,
this.hitLinkElement,
this.state,
[lastPointerUpCoords.x, lastPointerUpCoords.y],
this.deviceType.isMobile,

3
src/element/Hyperlink.tsx
View File

@ -337,6 +337,9 @@ export const isPointHittingLinkIcon = (
[x, y]: Point,
isMobile: boolean,
) => {
if (!element.link || appState.selectedElementIds[element.id]) {
return false;
}
const threshold = 4 / appState.zoom.value;
if (
!isMobile &&