sambruk/excalidraw
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Only insert text on double click when selection is enabled (#1937)

Browse Source 
This was an oversight to enable it for all the shapes. I don't believe that we want to be able to insert text on double click when drawing a rectangle for example. And it's definitely a broken experience when doing so for free draw.

Fixes part of #1935
This commit is contained in:
Christopher Chedeau 2020-07-27 14:05:52 -07:00 committed by GitHub
parent c0ca6bae37
commit 925db9dcca
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/components/App.tsx
View File

@ -1746,6 +1746,10 @@ class App extends React.Component<ExcalidrawProps, AppState> {
if (this.state.multiElement) { if (this.state.multiElement) {
return; return;
} }
// we should only be able to double click when mode is selection
if (this.state.elementType !== "selection") {
return;
}
const selectedElements = getSelectedElements( const selectedElements = getSelectedElements(
globalSceneState.getElements(), globalSceneState.getElements(),