Encapsulate SceneHistory. A little. (#1016)

This commit is contained in:
Kent Beck 2020-03-20 10:45:30 -07:00 committed by GitHub
parent 46e619d800
commit dc618ab122
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 12 deletions

View File

@ -2432,10 +2432,7 @@ export class App extends React.Component<any, AppState> {
this.broadcastSceneUpdate();
}
if (history.isRecording()) {
history.pushEntry(this.state, globalSceneState.getAllElements());
history.skipRecording();
}
history.record(this.state, globalSceneState.getAllElements());
}
}

View File

@ -123,17 +123,17 @@ export class SceneHistory {
return null;
}
isRecording() {
return this.recording;
}
skipRecording() {
this.recording = false;
}
// Suspicious that this is called so many places. Seems error-prone.
resumeRecording() {
this.recording = true;
}
record(state: AppState, elements: readonly ExcalidrawElement[]) {
if (this.recording) {
this.pushEntry(state, elements);
this.recording = false;
}
}
}
export const createHistory: () => { history: SceneHistory } = () => {